TNL-930: Turn off Student Notes when Harvard Annotation Tool is enabled. - #6340
Conversation
There was a problem hiding this comment.
@polesye Instead of Note: Harvard Annotation... I would use Warning: Harvard Annotation..., Note can be confusing in the Notes context and doesn't emphasize enough that things won't work if Harvard Annotation Tool is on.
There was a problem hiding this comment.
According to the PMs, Harvard is the only school that has access to the Harvard annotation tool. I'm concerned that people who see it mentioned here will start asking about the tool and wanting to use it - so I think this message should go directly from PMs to Harvard instead of appearing to all of our worldwide users in Studio.
Also, can the display name be "Enable Student Notes," since that's what we've been calling this feature?
Assuming we can change the display name and we don't want to mention any other annotation tools in the UI, I'd revise this text to just the following:
Enable Student Notes
Enter true or false. If true, students can use the Student Notes feature.
There was a problem hiding this comment.
Enable Student Notes
Enter true or false. If true, students can use the Student Notes feature.
Done. Thanks.
|
@srpearce sandbox is created ^^. |
There was a problem hiding this comment.
Tests that get_html is not wrapped...
There was a problem hiding this comment.
Tests that get_html is not wrapped...
Thanks, fixed.
|
@polesye 👍 |
1 similar comment
|
@polesye 👍 |
There was a problem hiding this comment.
display name: Enable Student Notes in Course
help: Enter true or false. If true, students can use the Student Notes feature.
I hesitate to use something like "Make Student Notes Visible" because that could raise questions about whether students can make notes even if this value is set to false, but can only see them if this is set to true. "Enable Student Notes in Course" indicates more clearly that a student can't perform any action with Notes at all unless this value is set to true.
If "Enable Student Notes in Course" is too long, I'd suggest changing the display name for edxnotes to "Enable Student Notes in Platform" (since fewer people will see this) and changing the display name for edxnotes_visibility to "Enable Student Notes".
There was a problem hiding this comment.
display name: Enable Student Notes in Course
help: Enter true or false. If true, students can use the Student Notes feature.I hesitate to use something like "Make Student Notes Visible" because that could raise questions about whether students can make notes even if this value is set to false, but can only see them if this is set to true. "Enable Student Notes in Course" indicates more clearly that a student can't perform any action with Notes at all unless this value is set to true.
If "Enable Student Notes in Course" is too long, I'd suggest changing the display name for edxnotes to "Enable Student Notes in Platform" (since fewer people will see this) and changing the display name for edxnotes_visibility to "Enable Student Notes".
This field is not user visible. So, I just removed display name, and updated help string so Indicates current state of visibility of the Student Notes. This can be changed by a student to show/hide all notes in Platform. For more information: https://openedx.atlassian.net/browse/TNL-661
@srpearce what do you think?
829a6ac to
fea25b4
Compare
4296776 to
487c799
Compare
There was a problem hiding this comment.
I'd change it to:
Student Notes Visibility
Indicates whether Student Notes are visible in the course. Students can also show or hide their notes in the courseware.
There was a problem hiding this comment.
I'd change it to:
Student Notes Visibility
Indicates whether Student Notes are visible in the course. Students can also show or hide their notes in the courseware.
changed.
487c799 to
30de79a
Compare
30de79a to
53772e8
Compare
53772e8 to
8c58025
Compare
|
👍 once tests pass |
TNL-930: Turn off Student Notes when Harvard Annotation Tool is enabled.
5 participants
Disables Student Notes if one of
textannotation,imageannotation,videoannotationmodules exist in the list ofAdvanced Modules.There is still possibility to break
Student NotesandHarvard Annotation Tool:textannotation,imageannotation,videoannotationto theAdvanced Moduleslist;textannotation,imageannotation,videoannotationto the unit;Advanced Moduleslist => You can enable Student Notes now. If you have both modules in the sequential, it breaks one of these modules.I think we should write a good note about this situation.
@tymofij , @olmar, @jmclaus, @srpearce please review.
sandbox: http://studio.polesye.m.sandbox.edx.org/